Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurelia validation #246

Merged
merged 2 commits into from
Sep 1, 2016
Merged

Conversation

Ullfis
Copy link
Contributor

@Ullfis Ullfis commented Sep 1, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.154% when pulling 9de8f2d on Ullfis:aurelia-validation into a60b7c1 on aurelia-ui-toolkits:master.

@Ullfis Ullfis mentioned this pull request Sep 1, 2016
@Thanood Thanood merged commit beb322c into aurelia-ui-toolkits:master Sep 1, 2016
@Thanood
Copy link
Collaborator

Thanood commented Sep 1, 2016

Looks great, checking it out now.
Do you think we need an "error" color? I saw your static color in md-colors. I'll have a look what we can do about that.

@Ullfis
Copy link
Contributor Author

Ullfis commented Sep 1, 2016

Error color sounds great 😄 Maybe also consider a success color.

@Thanood
Copy link
Collaborator

Thanood commented Sep 1, 2016

I'll add another issue for that.

Do you know if it's possible to have default values for html-only components (like md-colors)?
I'd like to not break existing code (by requiring two additional attributes) but still like to keep the simple html-only thing that it is today.

If it's not possible I simply add a js file.

@Ullfis
Copy link
Contributor Author

Ullfis commented Sep 1, 2016

I am not sure. Maybe a js file is the way to go here.

@Ullfis Ullfis deleted the aurelia-validation branch September 6, 2016 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants