Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added disabled bindable on md-input custom element #180

Merged

Conversation

Kukks
Copy link
Contributor

@Kukks Kukks commented May 10, 2016

@Thanood
Copy link
Collaborator

Thanood commented May 10, 2016

Please provide a sample in the docs for new features.
(as discussed in chat 😄 )

@Kukks
Copy link
Contributor Author

Kukks commented May 10, 2016

Done ;)

@Thanood Thanood merged commit 5b3b245 into aurelia-ui-toolkits:master May 10, 2016
@Thanood
Copy link
Collaborator

Thanood commented May 10, 2016

Thank you! 👍

@Thanood
Copy link
Collaborator

Thanood commented May 10, 2016

Please see here for some conventions we use to help auto-generate the changelogs.

@Thanood
Copy link
Collaborator

Thanood commented May 11, 2016

Please also remember to lint your changes. Got these linter errors:

sample\src\samples\input\basic-use.js
  8:4  error  Expected indentation of 4 space characters but found 0  indent

sample\src\samples\input\textarea.js
  8:4  error  Expected indentation of 4 space characters but found 0  indent

✖ 2 problems (2 errors, 0 warnings)

I propose using an editorconfig](http://editorconfig.org/#download) plugin for your editor of choice. It should automatically apply our formatting conventions set in a .editorconfig file.

@Thanood
Copy link
Collaborator

Thanood commented May 11, 2016

The PR is uploaded in 0.6.0 and visible in the app catalog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants