Skip to content

Component.prototype.invokeWithCallback handles the correct signature #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xcambar
Copy link
Contributor

@xcambar xcambar commented Sep 30, 2013

The arguments and return value of Component.prototype.invokeWithCallbacks is now the same as the internal invokeWithCallbacks. It proxies all the arguments to the latter:

  • it provides this as a context
  • it returns a promise.
  • it passes all the arguments.

It now returns a promise.

It handles its arguments the same way invokeWithCallbacks does internally and passes them gracefully
This was referenced Oct 1, 2013
sbellity added a commit that referenced this pull request Oct 1, 2013
…omponent

Component.prototype.invokeWithCallback handles the correct signature
@sbellity sbellity merged commit e436a01 into aurajs:master Oct 1, 2013
@xcambar xcambar deleted the hotfix/invoke_with_callback_on_component branch October 1, 2013 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants