-
Notifications
You must be signed in to change notification settings - Fork 0
#268 Language detection and selection #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
aura-historia | 6a5f02f | Commit Preview URL Branch Preview URL |
Dec 23 2025, 10:02 PM |
|
Detecting the language initially on the server might be a bit challenging. So far we're almost always triggering hydration errors cause the SSR'ed language doesnt match the client. Need to check our options there more closely |
|
I resolved this by adding a server function which uses client cookies or as a fallback the headers on the clients requests to tell the server the preferred lang. The only thing missing now are the translations for all of the Amplify Components. I'll have to wait for #249, before I can properly continue here. |
bruderj15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing missing now are the translations for all of the Amplify Components. I'll have to wait for #249, before I can properly continue here.
Awesome!
Looks neat and changing seems super smooth.
I would propose one enhancements: Suffix the flag with the name of the language (think older people having to look at the tiny flag).
Apart from that, one question: Can we, by any chance, move the flag-toggle to the top into the nav-bar?
This would underline one of our main aspects: internationalization.
One could argue that this isn't necessary as we now successfully detect the preferred language anyways. Up to discussion.
Should we translate the name of the language to the current language or show them in their native names? (e.g. German vs. Deutsch, French vs Français vs Französisch, ...)
Moving it would be easily possible, it would pollute the header a bit though. My thinking was, you'd have to use it at most only once or twice, since we remember the language you set there indefinitely. |
Native.
Alright, buying it. |
|
What about a similar drop-down for selecting preferred currency? |


fixes #268