Skip to content

Conversation

@lfranke42
Copy link
Contributor

@lfranke42 lfranke42 commented Dec 23, 2025

fixes #268

@lfranke42 lfranke42 changed the title /#268 language detection and selection #268 language detection and selection Dec 23, 2025
@lfranke42 lfranke42 self-assigned this Dec 23, 2025
@lfranke42 lfranke42 changed the title #268 language detection and selection #268 Language detection and selection Dec 23, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
aura-historia 6a5f02f Commit Preview URL

Branch Preview URL
Dec 23 2025, 10:02 PM

@lfranke42
Copy link
Contributor Author

Detecting the language initially on the server might be a bit challenging. So far we're almost always triggering hydration errors cause the SSR'ed language doesnt match the client. Need to check our options there more closely

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@lfranke42
Copy link
Contributor Author

Detecting the language initially on the server might be a bit challenging. So far we're almost always triggering hydration errors cause the SSR'ed language doesnt match the client. Need to check our options there more closely

I resolved this by adding a server function which uses client cookies or as a fallback the headers on the clients requests to tell the server the preferred lang.

The only thing missing now are the translations for all of the Amplify Components. I'll have to wait for #249, before I can properly continue here.

Copy link
Contributor

@bruderj15 bruderj15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing missing now are the translations for all of the Amplify Components. I'll have to wait for #249, before I can properly continue here.

Awesome!

Looks neat and changing seems super smooth.
I would propose one enhancements: Suffix the flag with the name of the language (think older people having to look at the tiny flag).

Apart from that, one question: Can we, by any chance, move the flag-toggle to the top into the nav-bar?
This would underline one of our main aspects: internationalization.
One could argue that this isn't necessary as we now successfully detect the preferred language anyways. Up to discussion.

@lfranke42
Copy link
Contributor Author

I would propose one enhancements: Suffix the flag with the name of the language (think older people having to look at the tiny flag).

Should we translate the name of the language to the current language or show them in their native names? (e.g. German vs. Deutsch, French vs Français vs Französisch, ...)

Apart from that, one question: Can we, by any chance, move the flag-toggle to the top into the nav-bar?
This would underline one of our main aspects: internationalization.
One could argue that this isn't necessary as we now successfully detect the preferred language anyways. Up to discussion.

Moving it would be easily possible, it would pollute the header a bit though. My thinking was, you'd have to use it at most only once or twice, since we remember the language you set there indefinitely.

@bruderj15
Copy link
Contributor

Should we translate the name of the language to the current language or show them in their native names? (e.g. German vs. Deutsch, French vs Français vs Französisch, ...)

Native.

Moving it would be easily possible, it would pollute the header a bit though. My thinking was, you'd have to use it at most only once or twice, since we remember the language you set there indefinitely.

Alright, buying it.

@bruderj15
Copy link
Contributor

What about a similar drop-down for selecting preferred currency?
Right next to the language one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Language support

3 participants