Skip to content

Conversation

@hagenw
Copy link
Member

@hagenw hagenw commented Jan 27, 2026

pandas 3.0.0 is showing a deprecation warning when using .astype(..., copy=False) as copy will be removed. With copy=False it will not change the type if it matches already the requested one. But we have anyway an if-statement before that runs the code only if the types do not match, so it should be safe to remove it.

Summary by Sourcery

Enhancements:

  • Simplify dtype conversion for string columns during pickle loading by relying on astype("string") without the deprecated copy parameter.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the deprecated copy keyword argument from a specific astype() call in table loading, relying on existing type-mismatch guards to preserve behavior while eliminating the pandas 3.0 deprecation warning.

File-Level Changes

Change Details Files
Update string column type conversion to avoid deprecated astype(copy=...) usage.
  • Replace astype("string", copy=False) with astype("string") for object-typed string scheme columns during pickled table loading
  • Preserve behavior by continuing to rely on the preceding type-check condition to ensure conversion is only performed when dtype actually differs
audformat/core/table.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (591af86) to head (4bfe37c).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
Files with missing lines Coverage Δ
audformat/core/table.py 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hagenw hagenw merged commit 5990e02 into dev Jan 27, 2026
13 checks passed
@hagenw hagenw deleted the remove-deprecation-warning branch January 27, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants