-
Notifications
You must be signed in to change notification settings - Fork 1
TST: fix remaining tests #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdjusts misc table tests to explicitly specify index dtypes and expected dtype parameters to align with pandas 3.0’s change of default empty index dtype from File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The choice between
dtype="object"anddtype="string"in different test cases is not obvious; consider adding a small helper or comment (in the test factory or parameterization) that makes the intended distinction between legacy and new pandas behavior explicit and consistent. - There is quite a bit of repetition in constructing
pd.Index([...], name="idx", dtype=...)and similar objects; consider introducing a small factory/helper in the tests to reduce duplication and make future dtype-related adjustments easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The choice between `dtype="object"` and `dtype="string"` in different test cases is not obvious; consider adding a small helper or comment (in the test factory or parameterization) that makes the intended distinction between legacy and new pandas behavior explicit and consistent.
- There is quite a bit of repetition in constructing `pd.Index([...], name="idx", dtype=...)` and similar objects; consider introducing a small factory/helper in the tests to reduce duplication and make future dtype-related adjustments easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes errors in
tests/test_misc_table.pyrelated to the switch fromobjecttostringas default new dtype for empty indices in pandas 3.0.Summary by Sourcery
Adjust miscellaneous table tests for pandas 3.0 index dtype behavior changes.
Tests: