-
Notifications
You must be signed in to change notification settings - Fork 1
TST: fix doctests outputs #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add failing test * Make test pandas 3.0.0 compatible * Fix set_index_dtypes() for pandas 3.0 * Add comment * Fix doctests * Update segmented_index() * Use segmented_index in test * Add test for segmented_index
* pandas 3.0: fix utils.hash() * Fix comment * Remove unneeded code * Add more tests * Preserve ordered setting * Update comment
* Fix categorical dtype with Database.get() * Update tests * Add additional test * Improve code * Clean up comment * We converted to categorical data * Simplify test * Simplify string test
* Require timedelta64[ns] in assert_index() * Add tests for mixed cases
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates doctest examples to be compatible with pandas 3.0, explicitly enforcing object dtype in a Series example and adjusting documented/expected timedelta[ns] string representations to match the new 6-decimal-place display format. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider adding a short inline comment in the doctest explaining why
dtype="object"is explicitly specified (to stabilize output across pandas 3.x), so future maintainers don’t “simplify” it back and accidentally break the doctest again.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short inline comment in the doctest explaining why `dtype="object"` is explicitly specified (to stabilize output across pandas 3.x), so future maintainers don’t “simplify” it back and accidentally break the doctest again.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Adjusts doctest output to catch
objectvs.strcases and the new reduced otuput fortimedelta[ns]entries in pandas 3.0 (it does now only show 6 places instead of 9, e.g.00:00:00.063022instead of00:00:00.063022023.Summary by Sourcery
Documentation: