Skip to content

Return categorical dtype when get() is called with a mapping #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hagenw merged 4 commits into from
Jan 18, 2023
Merged

Return categorical dtype when get() is called with a mapping #347

hagenw merged 4 commits into from
Jan 18, 2023

Conversation

@frankenjoe
Copy link
Collaborator

@frankenjoe frankenjoe commented Jan 17, 2023 •
edited
Loading

Closes #317

Solves the issue described in #317 and adds a test for it.

@frankenjoe frankenjoe changed the title WIP: Return categorical dtype when get() is called with a mapping Return categorical dtype when get() is called with a mapping Jan 17, 2023
@frankenjoe frankenjoe requested a review from hagenw January 17, 2023 14:53
@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #347 (c6d675b) into main (3901a51) will not change coverage.
The diff coverage is 100.0%.

Impacted Files Coverage Δ
audformat/core/column.py 100.0% <100.0%> (ø)
audformat/core/table.py 100.0% <0.0%> (ø)

hagenw
hagenw reviewed Jan 18, 2023
View reviewed changes
frankenjoe and others added 2 commits January 18, 2023 09:25
@frankenjoe @hagenw
Update tests/test_column.py
ad3c32b 
Co-authored-by: Hagen Wierstorf <hwierstorf@audeering.com>
@frankenjoe
TST: fix flake
c6d675b
@hagenw hagenw merged commit cc792d2 into main Jan 18, 2023
@hagenw hagenw deleted the fix-get-map-dtype branch January 18, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hagenw hagenw hagenw left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Always return categorical dtype when get() is called with a mapping

3 participants

@frankenjoe @hagenw