Binary type for attribute was getting overridden to Value type for 5.1, so passing type to attribute api. #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyankatapar
force-pushed
the
v3.1.0_CD-182663_rails5.1
branch
2 times, most recently
from
89ca46c to
17ff856
Compare
priyankatapar
changed the title
priyankatapar
force-pushed
the
v3.1.0_CD-182663_rails5.1
branch
2 times, most recently
from
739c3fd to
f334dab
Compare
…es, attr_encrypted uses `columns_hash` to identify column type in table.
priyankatapar
force-pushed
the
v3.1.0_CD-182663_rails5.1
branch
from
f334dab to
e6f4893
Compare
|
@priyankatapar thanks for taking a stab at this. There's a lot of change unrelated to your fix. Let's keep the change focused. Moreover, something in your changes has entirely broken the build. Perhaps with a focused change this won't be an issue? Lastly, we try to keep this code tested as well as possible. I don't think you have a test that asserts the behavior of your change. Please add tests. |
|
@saghaulor, any update on this PR? Can we go forward with approach? Is the test changes fine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary type for attribute was getting changed to Value type for Rails 5.1 due to this, so passing type to attribute api.
Please note:
After the above fix Unit tests were failing as the tables did not exist in database.
Fixed unit tests, the tables need to be present in DB before the ActiveRecord classes are loaded as
attr_encryptedcall internally usescolumns_hashto identify the attribute type.