clean: Update Nova Keystone Jobs to match common architecture #273
Conversation
nova/templates/configmap-bin.yaml
Outdated
| {{- include "helm-toolkit.keystone_user" . | indent 4 }} | ||
| init.sh: | | ||
| {{ tuple "bin/_init.sh.tpl" . | include "helm-toolkit.template" | indent 4 }} | ||
| post.sh: | |
There was a problem hiding this comment.
Should be removed...
wilkers-steve
left a comment
wilkers-steve
left a comment
There was a problem hiding this comment.
Pete, this looks good. Thanks for cleaning this up. Also, thanks for cleaning up the dependency list here. LGTM 👍
|
@wilkers-steve thanks for the review :) I need to do a little bit more cleanup for a couple of things I missed, I'll ping you soon as they are ready. |
v1k0d3n
changed the title
|
@wilkers-steve I've made a few minor tweaks, could you please review this again at your convenience. |
|
LGTM @intlabs |
v1k0d3n
left a comment
v1k0d3n
left a comment
There was a problem hiding this comment.
LGTM. only one question that doesn't prevent any of this getting merged as is, honestly.
| @@ -132,60 +134,48 @@ memcached: | |||
| dependencies: | |||
There was a problem hiding this comment.
thanks for your incredible patience while i've been fighting the good fight (day job/i.e. calls). you may have already addressed this in another PR that I'm about to get to soon, but QQ:
do we want dependency order to be the same across all charts (i.e. db_init > db_sync > api etc? i know you're in the middle of an awesome effort to clean this up, so you may have actually tacked this as part of another PR I'm about to review.
There was a problem hiding this comment.
sounds good. tracked on the roadmap now. thanks.
v1k0d3n
changed the title
v1k0d3n
changed the title
4 participants
What is the purpose of this pull request?: To bring Nova Keystone Jobs inline with other services.
What issue does this pull request address?: N/A
Notes for reviewers to consider:
This PR should bring Nova Keystone Jobs inline with Cinder and Heat, and is part of the effort to standardize the common elements in charts prior to moving to OpenStack.
Specific reviewers for pull request:
@alanmeadows @v1k0d3n @larryrensing @wilkers-steve