[Chart] Adding manila helm chart #188
Conversation
alanmeadows
left a comment
alanmeadows
left a comment
There was a problem hiding this comment.
This is a good start. Since this is a WIP, this isn't a complete review but a few comments that may help.
| quota_share_networks = 0 | ||
|
|
||
| [cinder] | ||
| auth_url = {{.Values.global.keystone_api_endpoint_protocol_admin}}://{{include "keystone_api_endpoint_host_admin" .}}:{{ .Values.global.keystone_api_port_admin }}/v3 |
There was a problem hiding this comment.
This needs to follow [pull request 142] (#142) method for endpoint lookup.
There was a problem hiding this comment.
@alanmeadows we should get @intlabs work pulled in, and like you recommended in #142 split some of the work if it eases his load as he transitions (i'm sure he'll be pretty busy or even offline soon). this way we can clearly define that this is the expectation going forward. once it's in, we can remove the development references around endpoint "dragons". :)
| [cinder] | ||
| auth_url = {{.Values.global.keystone_api_endpoint_protocol_admin}}://{{include "keystone_api_endpoint_host_admin" .}}:{{ .Values.global.keystone_api_port_admin }}/v3 | ||
| auth_plugin = v3password | ||
| region_name = {{.Values.global.region}} |
There was a problem hiding this comment.
No global usage in openstack-helm
There was a problem hiding this comment.
@stannum-l to @alanmeadows' point, this document could help some: Openstack-Helm Philosophy.
There was a problem hiding this comment.
Thanks for the feedback. I will do another pass to change all the auth_url's (and others) in the various service this week. This was the template pulled from the SAP OS-helm to understand the dependencies needed by manila.
|
|
||
|
|
||
| [nova] | ||
| auth_url = {{.Values.global.keystone_api_endpoint_protocol_admin}}://{{include "keystone_api_endpoint_host_admin" .}}:{{ .Values.global.keystone_api_port_admin }}/v3 |
There was a problem hiding this comment.
Same as above - there is a pattern for endpoint lookup
| project_domain_name = {{.Values.global.keystone_service_domain}} | ||
|
|
||
| [neutron] | ||
| url = {{.Values.global.neutron_api_endpoint_protocol_internal}}://{{include "neutron_api_endpoint_host_internal" .}}:{{ .Values.global.neutron_api_port_internal }} |
| connection = mysql+pymysql://{{ .Values.database.manila_user }}:{{ .Values.database.manila_password }}@{{ .Values.database.address }}/{{ .Values.database.manila_database_name }} | ||
|
|
||
| [keystone_authtoken] | ||
| auth_uri = {{ .Values.keystone.auth_uri }} |
manila/templates/job-db-init.yaml
Outdated
| template: | ||
| metadata: | ||
| annotations: | ||
| pod.beta.kubernetes.io/init-containers: |
There was a problem hiding this comment.
There is now a macro pattern to follow for dependency checking in common to condense this
There was a problem hiding this comment.
Will fix in the next patch set.
stannum-l
changed the title
| - name: manila-scheduler | ||
| image: {{ .Values.images.scheduler }} | ||
| imagePullPolicy: {{ .Values.images.pull_policy }} | ||
| command: |
There was a problem hiding this comment.
Add some resource limits to this manifest
Heat Client Endpoint Lookup
Adding manila service support for openstack-helm. **What issue does this pull request address?**: Issue #178 **Notes for reviewers to consider:** None **Specific reviewers for pull request:** alanmeadows, v1k0d3n, larryrensing
| B64_DIRS := helm-toolkit/secrets | ||
| B64_EXCLUDE := $(wildcard helm-toolkit/secrets/*.b64) | ||
|
|
||
| CHARTS := ceph mariadb etcd postgresql rabbitmq memcached keystone glance horizon neutron nova cinder heat maas |
There was a problem hiding this comment.
Looks like the removal of MaaS and PostgreSQL put you into a merge conflict
|
Thanks for this work @stannum-l. We'll file a blueprint once we're in OpenStack to track this work going forward. Until then, we'll leave this PR open for you to reference after that point. |
|
closing this PR in favor of moving the work to Openstack proper: https://github.com/openstack/openstack-helm |
5 participants
What is the purpose of this pull request?:
Adding manila service support for openstack-helm.
What issue does this pull request address?:
Issue#178
Notes for reviewers to consider:
None
Specific reviewers for pull request:
@intlabs @alanmeadows @v1k0d3n @larryrensing