Add resources limits and requests for some charts #163
Conversation
Squah all commits in one.
|
Hey @alanmeadows, I think this pull request is good to go. |
|
Build finished. |
There was a problem hiding this comment.
This is cleaner then the original closed pull request, lacking the issues with stale init-container work. There is just one (but consistent) indentation issue with the {{ if }} conditional and {{ end }} statements across all charts. It should align with the line preceding it.
glance/templates/deployment-api.yaml
Outdated
| @@ -35,6 +35,15 @@ spec: | |||
| - name: glance-api | |||
| image: {{ .Values.images.api }} | |||
| imagePullPolicy: {{ .Values.images.pull_policy }} | |||
| {{- if .Values.resources.enabled }} | |||
There was a problem hiding this comment.
@Ciello89 Looks like an indendation issue here - this should line up with L37.
glance/templates/deployment-api.yaml
Outdated
| requests: | ||
| cpu: {{ .Values.resources.api.requests.cpu | quote }} | ||
| memory: {{ .Values.resources.api.requests.memory | quote }} | ||
| {{- end }} |
There was a problem hiding this comment.
Same here - this should line up with L37.
|
Build finished. |
memcached/templates/deployment.yaml
Outdated
| {{- if .Values.resources.enabled }} | ||
| resources: | ||
| limits: | ||
| cpu: {{ .Values.resources.api.limits.cpu }} |
There was a problem hiding this comment.
for consistency you should add {{ .... | quote }} in memcached also
Cleaning pull request #103
This change is