ci: Temporarily allow mismatched_lifetime_syntaxes lint in PACs
#887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeaurivage
force-pushed
the
fix-pac-ci
branch
2 times, most recently
from
be2675d to
1823422
Compare
|
@jbeaurivage I saw your messages in Rust Embedded about svd2rust - are you looking in to using a newer one? |
|
@ianrrees ideally yes, I'm in no rush, but I felt like updating the pacs would be better than adding another lint exception. Not if it breaks the HAL though! Looks like on nightly, we have some new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mismatched_lifetime_syntaxesis a new lint introduced in rustc 1.84. PACs currently fail CI on nightly because of this.Temporarily allow the lint. The
#![allow]statement should be removed fromupdate-pacs.shwhen we start generating PACs withsvd2rust >= 0.36.2: see rust-embedded/svd2rust#936 (currently unreleased).