Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review JOSE submission - Generate geographical unit data #42

Open
jwagemann opened this issue Nov 2, 2020 · 1 comment
Open

Review JOSE submission - Generate geographical unit data #42

jwagemann opened this issue Nov 2, 2020 · 1 comment
Assignees

Comments

@jwagemann
Copy link

  • maybe use a table to describe administrative units
  • the section does not tell me why it is important to generate geographical unit data
  • here examples of different programming languages are shown again and I’d say it would be better to stick to one example in one programming language and to refer to packages in other programming languages
@jrising
Copy link
Collaborator

jrising commented Feb 24, 2021

Thank you for these comments! @atrisovic has gone through them, with responses below.

maybe use a table to describe administrative units

Thanks for the suggestion! A table is added to illustrate the administrative units.

the section does not tell me why it is important to generate geographical unit data

An explanation is added in the opening paragraph.

here examples of different programming languages are shown again and I'd say it would be better to stick to one example in one programming language and to refer to packages in other programming languages

As folks in the field frequently use Stata, R and Python, we decided to keep different languages throughout the tutorial. However, this should now be much ‘cleaner’ and easier to understand, as we make use of tabs, which is a new feature of Jupyter Book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants