Repository navigation
Conversation
zoeyrose
changed the title
zoeyrose
marked this pull request as ready for review
October 5, 2026 02:07
zoeyrose
added a commit
to atrinik/atrinik
that referenced
this pull request
Oct 5, 2026
## Summary Expose the server-owned `writing-books` preset through the workspace scenario CLI and shell completion for [the Classic book-writing issue](atrinik/classic#564). Companions: [Classic PR #567](atrinik/classic#567) and [content PR #266](atrinik/content#266). ## Implementation / behavior - Add `writing-books` to the existing preset allowlists and document isolated creation/show/reset usage. - Extend scenario forwarding and completion coverage. Gameplay items, skills and account provisioning remain owned by the Classic server; content is `content@main` and its Classic-target artifact. ## Validation - 31 focused scenario/completion tests passed (3 shell-dependent skips). - Compileall, guidance inventory, manifest validation and whitespace checks passed. - Full suite executed: 2,063 tests. Targeted reruns corrected private fixture history, temporary-path and umask differences. Nine residual failures/errors also reproduce at the base revision: unsafe shared Git configuration permissions, a native-context fixture expectation and unavailable `-lz`; the full suite is not reported as passing. - The preset provisioned the isolated Classic scenario used for 22 authenticated gameplay checks and controlled restart persistence. Runtime stopped cleanly. - Independent review completed. ## Limitations / follow-up Hosted workspace CI passes on the published revision. Requires the companion Classic implementation and Classic-target content. The local full-suite environment limitations above remain; no host permissions, trust policy or package installation were changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Classic writing supplies and help required by Classic book-writing issue.
Implementation / behavior
icon_7soul1_i_ink.101face.This change targets
content@mainand its Classic-target artifact. It accompanies Classic PR #567.Validation
Limitations / follow-up
Requires the companion Classic book-editor implementation. Merge and publication of the Classic-target content artifact are separate operations.