Repository navigation
feat(archetypes): light transient magic glows - #209
Merged
Merged
Conversation
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - give the five transient `meffect_*` magic glows radius-1 light using their established blue, green, pink, purple, and yellow palette colors - preserve every animation, timing, lifecycle, saving, spell, potion, and gameplay field - reconcile Morliana's permanent Great Blue Crystal composition to one intentional neutral `light9` provider by locally disabling both permanent blue overlays and removing all eight surrounding helpers - refresh the authored semantic lighting review for source-only, runtime-created, and map-local instances without adding generated capture artifacts Closes #94. ## Coordinates - current base: `main@f876373787d45ecc124da1568e74cdab5742aecb` - head branch: `feat/94-transient-magic-glows-main` - validated head: `cfa54980114f60973bab30d6664a3deea5044b50` - worktree: `/workspaces/atrinik/workspace/worktrees/content/issue-94-transient-magic-glows-main` ## Validation - `python3 tools/world_content_audit.py lights --check` — 130 archetypes, 10 artifacts, 11,741 instances across 641 maps; 6,885 explicit colors, 4,996 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 165 tests plus lossless content, schema, catalog, contracts, syntax, licensing, and isolated runtime collection passed - `jq empty maps/light-source-review.json` - `git diff --check` - `./atrinik build all --profile issue-94-transient-magic-glows --test` — 113/114 tests passed; all relevant lighting, server, plugin, and runtime suites passed. The unchanged large smooth movement benchmark hit its fixed 900-second timeout, already tracked by atrinik/classic#196 and atrinik/classic#258. ## Runtime verification Exact isolated Classic profiles at Classic `a10957c86f2df0f7fb66e40830f428f0a45b02cc` and content `e5d73e9955295bf56e78cb227d4939e3331d8637` executed all 13 spell-table consumer IDs and all three potion branches, including successful, no-condition/no-target, cursed, beneficial, rapid, and clustered paths. Radius-1 colored effects rendered as bounded local glows and expired without residue, saturation, or visible flicker. Morliana's Great Blue Crystal was verified in both smooth and discrete renderers: each shows one centered focal composition; discrete exposes the expected single-source square falloff with no adjacent radius-9 stack, while smooth produces the corresponding blended pool. Timed capture confirmed transient effects expire cleanly. No capture artifacts are committed. Classic's separately reproduced supervisor/server control livelock remains tracked at atrinik/classic#262. It recurred after runtime completion both with explicitly closed Python-console sessions and in a no-console command-only topology; the wrapper correctly retained those exact leases for safe diagnosis. This is independent of the content diff and does not invalidate the completed gameplay/rendering observations. The replacement runtime remains unavailable at the integration boundaries tracked by atrinik/atrinik#266, atrinik/atrinik#269, and atrinik/atrinik#270. The canonical `main` source independently passes its authored and semantic contracts and publishes the Classic target from this same immutable revision. ## Evidence policy No renderer screenshots, contact sheets, capture manifests, proof maps, or capture tooling are committed. Optional diagnostics remain ignored under `build/` or deployment-owned output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meffect_*magic glows radius-1 light using their established blue, green, pink, purple, and yellow palette colorslight9provider by locally disabling both permanent blue overlays and removing all eight surrounding helpersCloses #94.
Coordinates
main@6047304e5f20ee3b95c04656a08cf74dcb0d6597feat/94-transient-magic-glows-main467fedb63277f0019af2bc25d1b59f712706d1be/workspaces/atrinik/workspace/worktrees/content/issue-94-transient-magic-glows-mainValidation
python3 tools/world_content_audit.py lights --check— 130 archetypes, 10 artifacts, 11,741 instances across 641 maps; 6,885 explicit colors, 4,996 intentional neutral, zero unreviewedpython3 tools/validate.py— 165 tests plus lossless content, schema, catalog, contracts, syntax, licensing, and isolated runtime collection passedjq empty maps/light-source-review.jsongit diff --check./atrinik build all --profile issue-94-transient-magic-glows --test— 113/114 tests passed; all relevant lighting, server, plugin, and runtime suites passed. The unchanged large smooth movement benchmark hit its fixed 900-second timeout, already tracked by perf(client): benchmark sustained map movement and cache recovery classic#196 and perf(client): add attributable lighting movement benchmarks classic#258.Runtime verification
Exact isolated Classic profiles at Classic
a10957c86f2df0f7fb66e40830f428f0a45b02ccand content625ad548c394b75afcf04443275cb57cb77fd151executed all 13 spell-table consumer IDs and all three potion branches, including successful, no-condition/no-target, cursed, beneficial, rapid, and clustered paths. Radius-1 colored effects rendered as bounded local glows and expired without residue, saturation, or visible flicker.Morliana's Great Blue Crystal was verified in both smooth and discrete renderers: each shows one centered focal composition; discrete exposes the expected single-source square falloff with no adjacent radius-9 stack, while smooth produces the corresponding blended pool. Timed capture confirmed transient effects expire cleanly. No capture artifacts are committed.
Classic's separately reproduced supervisor/server control livelock remains tracked at atrinik/classic#262. It recurred after runtime completion both with explicitly closed Python-console sessions and in a no-console command-only topology; the wrapper correctly retained those exact leases for safe diagnosis. This is independent of the content diff and does not invalidate the completed gameplay/rendering observations.
The replacement runtime remains unavailable at the integration boundaries tracked by atrinik/atrinik#266, atrinik/atrinik#269, and atrinik/atrinik#270. The canonical
mainsource independently passes its authored and semantic contracts and publishes the Classic target from this same immutable revision.Evidence policy
No renderer screenshots, contact sheets, capture manifests, proof maps, or capture tooling are committed. Optional diagnostics remain ignored under
build/or deployment-owned output.