Skip to content

feat(archetypes): make magic-wall runes emit restrained red light - #206

Merged
zoeyrose merged 3 commits into
mainfrom
feat/93-magic-wall-runes-main
Aug 13, 2026
Merged

zoeyrose merged 3 commits into
mainfrom
feat/93-magic-wall-runes-main

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Aug 13, 2026 •

Copy link
Copy Markdown
Member

Summary

  • give every visible magic_wall a persistent radius-1 ff3030 rune-presence cue without coupling light to damage or switch state
  • inventory all 57 placements across ten maps and explicitly reconcile all 12 current same-tile emitters
  • make same-tile fixture dispositions fail closed, with regression coverage and maintainer guidance

Coordinates

  • Base: main at 94eb4d16f7cd46dd4b9a749214e5ae33198b3679
  • Head: feat/93-magic-wall-runes-main at 110e6d8719117accfb50d5fe9a0758a09db68c11
  • Worktree: workspace/worktrees/content/issue-93-magic-wall-runes-main
  • Commits: 462e04352 feat(archetypes): illuminate magic-wall runes; 1d133b8a5 docs(lighting): record magic-wall runtime review; 110e6d871 chore(content): merge latest main into magic-wall work

Validation

  • python3 -m unittest tools.tests.test_world_content_audit -v — 4 tests passed
  • python3 tools/world_content_audit.py lights --check — 122 archetypes, 10 artifacts, 11,748 instances across 641 maps, zero unreviewed emitters
  • python3 tools/validate.py — passed, including 164 tests and catalog/schema/contracts/runtime collection checks
  • git diff --check — passed
  • isolated Classic profile build — integrated server/client build passed at Classic a10957c86f2df0f7fb66e40830f428f0a45b02cc with the runtime-equivalent magic-wall implementation tree (462e04352; later commits add review evidence and reconcile current-main audit contracts without changing the wall archetype)

Runtime verification

  • Profile/scenario/topology: issue-93-magic-wall-runes; scenario state scenario-issue-93-magic-wall-runes; dedicated display :93; topology stopped after review.
  • Representative active Plane of Creation walls were compared in smooth and discrete Classic. The radius-1 red cue stayed on the rune surface without flattening adjacent floor, fence, or corner contrast.
  • The same positioned 25-wall Underground City stress view was compared in smooth and discrete Classic after resetting the map and exercising its existing 7:10 magic-mouth trigger for connections 102 and 201. The existing INTRUDERS!!! and Security system activated!!! behavior remained intact.
  • The dense run did not become a continuous red wash or cross blocked geometry. Walls, water, rooms, and blocked boundaries retained their own contrast.
  • Paired views beside co-located wall 7:9 confirmed that the retained radius-9 light9 source still owns the blue room fill; the wall adds only its bounded rune cue, with no second room-scale pool.
  • Diagnostic captures remain ignored under build/reviews/; their exact view IDs and conclusions are recorded in maps/light-source-review.json as required by the issue amendment.

Review status

  • Source review confirms 57 walls across ten maps: 26 initially active and 31 initially disabled.
  • All 12 current same-tile sources are explicitly dispositioned: nine visible crystals, two invisible neutral room-fill helpers, and one visible amber wall torch.
  • Independent findings about audit documentation, same-tile identity regression coverage, and missing renderer evidence are fixed and validated.
  • Two fresh independent current-base whole-diff reviews found no actionable findings; all latest-head GitHub checks pass.

Closes #93.

@zoeyrose zoeyrose moved this to Review in Atrinik work Aug 13, 2026
@zoeyrose
zoeyrose marked this pull request as ready for review August 13, 2026 14:44
@zoeyrose
zoeyrose merged commit 4451050 into main Aug 13, 2026
8 checks passed
@zoeyrose
zoeyrose deleted the feat/93-magic-wall-runes-main branch August 13, 2026 15:00
@github-project-automation github-project-automation Bot moved this from Review to Done in Atrinik work Aug 13, 2026
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zoeyrose added a commit that referenced this pull request Aug 23, 2026
## Summary

- give every visible `magic_wall` a persistent radius-1 `ff3030`
rune-presence cue without coupling light to damage or switch state
- inventory all 57 placements across ten maps and explicitly reconcile
all 12 current same-tile emitters
- make same-tile fixture dispositions fail closed, with regression
coverage and maintainer guidance

## Coordinates

- Base: `main` at `39efa7caf1f09f4b9463c0d6a2bea7d6335a58e7`
- Head: `feat/93-magic-wall-runes-main` at
`bbfb7af9b4f7bdde7e8d4948e29d5de8b7da45ab`
- Worktree: `workspace/worktrees/content/issue-93-magic-wall-runes-main`
- Commits: `9f189e4ab feat(archetypes): illuminate magic-wall runes`;
`e31aecfd2 docs(lighting): record magic-wall runtime review`; `bbfb7af9b
chore(content): merge latest main into magic-wall work`

## Validation

- `python3 -m unittest tools.tests.test_world_content_audit -v` — 4
tests passed
- `python3 tools/world_content_audit.py lights --check` — 122
archetypes, 10 artifacts, 11,748 instances across 641 maps, zero
unreviewed emitters
- `python3 tools/validate.py` — passed, including 164 tests and
catalog/schema/contracts/runtime collection checks
- `git diff --check` — passed
- isolated Classic profile build — integrated server/client build passed
at Classic `a10957c86f2df0f7fb66e40830f428f0a45b02cc` with the
runtime-equivalent magic-wall implementation tree (`9f189e4ab`; later
commits add review evidence and reconcile current-main audit contracts
without changing the wall archetype)

## Runtime verification

- Profile/scenario/topology: `issue-93-magic-wall-runes`; scenario state
`scenario-issue-93-magic-wall-runes`; dedicated display `:93`; topology
stopped after review.
- Representative active Plane of Creation walls were compared in smooth
and discrete Classic. The radius-1 red cue stayed on the rune surface
without flattening adjacent floor, fence, or corner contrast.
- The same positioned 25-wall Underground City stress view was compared
in smooth and discrete Classic after resetting the map and exercising
its existing 7:10 magic-mouth trigger for connections 102 and 201. The
existing `INTRUDERS!!!` and `Security system activated!!!` behavior
remained intact.
- The dense run did not become a continuous red wash or cross blocked
geometry. Walls, water, rooms, and blocked boundaries retained their own
contrast.
- Paired views beside co-located wall 7:9 confirmed that the retained
radius-9 `light9` source still owns the blue room fill; the wall adds
only its bounded rune cue, with no second room-scale pool.
- Diagnostic captures remain ignored under `build/reviews/`; their exact
view IDs and conclusions are recorded in `maps/light-source-review.json`
as required by the issue amendment.

## Review status

- Source review confirms 57 walls across ten maps: 26 initially active
and 31 initially disabled.
- All 12 current same-tile sources are explicitly dispositioned: nine
visible crystals, two invisible neutral room-fill helpers, and one
visible amber wall torch.
- Independent findings about audit documentation, same-tile identity
regression coverage, and missing renderer evidence are fixed and
validated.
- Two fresh independent current-base whole-diff reviews found no
actionable findings; all latest-head GitHub checks pass.

Closes #93.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feat(archetypes): make magic-wall runes emit restrained red light

1 participant