Repository navigation
feat(lighting): illuminate colored portals - #176
Merged
Merged
Conversation
zoeyrose
marked this pull request as ready for review
August 12, 2026 02:08
This was referenced Aug 12, 2026
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
8 tasks done
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - give the five colored portal archetypes and town portal compact radius-1 light matching their visible art - reconcile every active map-local colored portal context, including the owner-gated Incuna private-beach portal found during independent cumulative review - preserve radius-zero hidden prototypes, gameplay fields, destinations, and line-native semantic-review provenance - update the deterministic authored-syntax maximum-map measurement without restoring retired renderer-evidence infrastructure Closes #86. ## Release pairing - Classic-compatible `1.x` delivery: #122, squash `df2433e82aba24ddb1d51131d804d9bd3d221fe0` - corrective `1.x` delivery: #171, squash `09a70c76c2604d340cd7ad684463bc1de5ecacd4` - this PR is the canonical `main` companion built only after both required `1.x` merges ## Coordinates - base: `main@b50a98d4e6c07676315905a7195790f2a6847657` - head: `4622d97bcad7544512b945664b6bf21d72432057` - remote tree: `039732b2308d5e78edca598d55ed163802f7b8ca` - commits: exactly one - changed paths: 31 ## Acceptance and preservation - exactly 38 custom portal-animation exits across 20 maps use radius 1 and the color matching their animation - 13 hidden portal prototypes retain explicit radius zero - the Incuna exit gains only `glow_radius 1` and `light_color 60d0ff`; its property, message, destination fields, coordinates, and typed-property behavior remain unchanged - the applicable authored behavior matches merged `1.x`; expected main-only formatting and provenance distinctions remain intact - `source_review`, the replacement-runtime boundary, and every existing `classic_views` entry are preserved - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/tests, or capture-bound review fields are restored ## Validation - `python3 tools/validate.py` — 129 tests plus plural, lossless core, semantic lights, schema, catalog, contracts, syntax prototypes, licensing/resource collection, and archives passed - `python3 tools/world_content_audit.py lights --check` — 110 archetypes, 10 artifacts, 11,490 instances across 634 maps; 5,803 explicit colors, 5,807 intentional neutral, zero unreviewed - authored-syntax snapshot — maximum map 95,662 bytes with SHA-256 `a09f…bfa4ae`; focused validation passed - `git diff --check` and JSON parsing — passed - fresh independent whole-diff review — zero actionable findings at the exact published tree ## Runtime boundary The replacement `main` stack does not yet provide integrated content runtime or renderer adapters. This delivery therefore validates authored, schema, catalog, semantic, and deterministic syntax contracts without substituting the Classic runtime or claiming new main-native rendering evidence. ## Program order This is stage #86 in #154. Squash-merge this PR into `main` only after its checks pass and the reported head remains exact. Then re-query both live tips before beginning #92; never bulk-refresh later stages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #86.
Release pairing
1.xdelivery: fix(lighting): illuminate colored portals #122, squashb033b8ca034acd26c19102ce90299a1ff5f698001.xdelivery: fix(lighting): light Incuna beach portal #171, squash58c20187edec7351177da7ee0b3008a82ce6439cmaincompanion built only after both required1.xmergesCoordinates
main@92d49f95a6aa0f00a70d54b119757b30491c08621c7ae264aa1bc9ae109a30b78ce1b000a35ee4b5039732b2308d5e78edca598d55ed163802f7b8caAcceptance and preservation
glow_radius 1andlight_color 60d0ff; its property, message, destination fields, coordinates, and typed-property behavior remain unchanged1.x; expected main-only formatting and provenance distinctions remain intactsource_review, the replacement-runtime boundary, and every existingclassic_viewsentry are preservedmaps/light-source-evidence/**, manifest, proof scene, capture tooling/tests, or capture-bound review fields are restoredValidation
python3 tools/validate.py— 129 tests plus plural, lossless core, semantic lights, schema, catalog, contracts, syntax prototypes, licensing/resource collection, and archives passedpython3 tools/world_content_audit.py lights --check— 110 archetypes, 10 artifacts, 11,490 instances across 634 maps; 5,803 explicit colors, 5,807 intentional neutral, zero unrevieweda09f…bfa4ae; focused validation passedgit diff --checkand JSON parsing — passedRuntime boundary
The replacement
mainstack does not yet provide integrated content runtime or renderer adapters. This delivery therefore validates authored, schema, catalog, semantic, and deterministic syntax contracts without substituting the Classic runtime or claiming new main-native rendering evidence.Program order
This is stage #86 in #154. Squash-merge this PR into
mainonly after its checks pass and the reported head remains exact. Then re-query both live tips before beginning #92; never bulk-refresh later stages.