Skip to content

fix(quests): isolate repeat reset prerequisites #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoeyrose merged 1 commit into from
Aug 12, 2026
Merged

fix(quests): isolate repeat reset prerequisites #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions maps/python/tests/QuestManager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,17 @@ def test_08_failed_quest_is_not_completed(self):
self.assertFalse(qm.fail("attempt"))

def test_09_failed_repeat_quest_resets(self):
old_level = activator.level
quest_container = activator.Controller().quest_container
old_magic = quest_container.magic
old_exp = quest_container.exp
self.addCleanup(setattr, activator, "level", old_level)
self.addCleanup(setattr, quest_container, "magic", old_magic)
self.addCleanup(setattr, quest_container, "exp", old_exp)
activator.level = 10
quest_container.magic = 0
quest_container.exp = 0

quest = {
"parts": OrderedDict((("attempt", {
"info": "",
Expand All @@ -481,6 +492,7 @@ def test_09_failed_repeat_quest_resets(self):
"repeat": True,
}
qm = QuestManager(activator, quest)
self.assertGreater(qm.get_qp_remaining(), 1)
qm.start("attempt")
self.assertTrue(qm.fail("attempt"))
self.assertTrue(qm.failed())
Expand Down