Repository navigation
feat(maps): light displayed crystal balls - #168
Merged
Merged
Conversation
This was referenced Aug 12, 2026
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
8 tasks done
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - make the Asteria fortune-teller and Marigold crystal balls fixed map-local displays - give each display a radius-1 `4060ff` focal light while keeping the collectible base archetype non-emitting - extend the cumulative `main` semantic review for the combined Marigold blue/pale-gold composition while retaining existing `classic_views` Closes #96. This is the canonical `main` companion to merged `1.x` PR #120 (`d28bf0ea0bced0bd962bd45869d92d74412f7a62`). ## Acceptance result - the crystal ball at Asteria `(11, 18)` and Marigold `(22, 9)` each gain only `no_pick 1`, `glow_radius 1`, and `light_color 4060ff` - the shared `crystal_ball` archetype remains non-emitting, preventing passive carried light for future collectible instances - both authored placements are confirmed fixed display scenery; there are no other map placements - Marigold’s radius-1 blue display and radius-1 pale-gold power crystal remain subordinate to stronger neutral helper lighting without stacked or clipped focal color - animation, value, type, names, placement, scripts, NPC context, and every unrelated gameplay field are preserved - both authored maps and both resulting semantic digests match merged `1.x` exactly ## Current inventory - 104 reviewed archetypes and 10 reviewed artifacts - 11,447 effective light instances across 632 maps - 5,754 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - existing `classic_views` remain unchanged as line-native historical provenance - optional renderer diagnostics remain generated only under ignored `build/` or deployment-owned output - replacement validation proves authored/schema/catalog/semantic compatibility without claiming integrated runtime rendering ## Coordinates - base: `main@4ac6d1a6e093b581f92d06563a224d175326647b` - head: `394b897f855b926ed7e951b061a371c57275c465` - commits: exactly one - changed paths: exactly three — `maps/light-source-review.json` and the two display maps ## Validation - `python3 tools/world_content_audit.py lights --check` — passed with the inventory above - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection passed - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused whole-diff review — exactly six intended map-local field additions across two maps; no archetype or unrelated gameplay changes; no changes to `views`, `evidence_focus`, or `classic_views` - cross-line comparison — both authored maps and both affected semantic digests match merged `1.x` ## Merge order Merge only after PR #120, which is already squash-merged to `1.x` as `d28bf0ea0bced0bd962bd45869d92d74412f7a62`. This is the second and final merge for #96 before proceeding to #86.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4060fffocal light while keeping the collectible base archetype non-emittingmainsemantic review for the combined Marigold blue/pale-gold composition while retaining existingclassic_viewsCloses #96.
This is the canonical
maincompanion to merged1.xPR #120 (ca3733ef1892a973402d60df173d3a12e8195e75).Acceptance result
(11, 18)and Marigold(22, 9)each gain onlyno_pick 1,glow_radius 1, andlight_color 4060ffcrystal_ballarchetype remains non-emitting, preventing passive carried light for future collectible instances1.xexactlyCurrent inventory
Evidence policy
maps/light-source-evidence/**, manifest, proof scene, capture tooling/test, or capture-boundviews/evidence_focusfield is restoredclassic_viewsremain unchanged as line-native historical provenancebuild/or deployment-owned outputCoordinates
main@81d71a575e0969ebe964893aa7c0ef9bfb63cb162c09a5f67c5ec4809fef9c351374c86263c5f507maps/light-source-review.jsonand the two display mapsValidation
python3 tools/world_content_audit.py lights --check— passed with the inventory abovepython3 tools/validate.py— 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection passedgit diff --checkjq empty maps/light-source-review.jsongit ls-files 'maps/light-source-evidence/*'— emptyviews,evidence_focus, orclassic_views1.xMerge order
Merge only after PR #120, which is already squash-merged to
1.xasca3733ef1892a973402d60df173d3a12e8195e75. This is the second and final merge for #96 before proceeding to #86.