Skip to content

fix(maps): light displayed crystal balls #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoeyrose merged 1 commit into from
Aug 12, 2026
Merged

fix(maps): light displayed crystal balls #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions maps/light-source-review.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,7 +1246,7 @@
},
"context_checks": {
"overlap": {
"rationale": "Compared overlapping red, purple, and cold-blue crystal pools in Brynknot Abyss in both renderers, plus the unchanged Bone Cairn control. The Marigold radius-1 power crystal sits beside stronger neutral helper lights and a currently non-emitting crystal ball without stacked focal color.",
"rationale": "Compared overlapping red, purple, and cold-blue crystal pools in Brynknot Abyss in both renderers, plus the unchanged Bone Cairn control. The Marigold radius-1 blue crystal-ball display and radius-1 pale-gold power crystal sit beside stronger neutral helper lights without stacked or clipped focal color.",
"status": "pass"
},
"linked-depth": {
Expand Down Expand Up @@ -3266,10 +3266,10 @@
},
"maps/shattered_islands/world_17_2_4": {
"uncolored_disposition": "neutral",
"rationale": "Rendered Wizards' Tower: Marigold with its radius-1 pale-gold power-crystal focus beside the currently non-emitting crystal ball; the stronger neutral helper lights retain the room hierarchy without stacked focal color.",
"rationale": "Rendered Wizards' Tower: Marigold with its fixed radius-1 blue crystal-ball display beside the radius-1 pale-gold power crystal; the stronger neutral helper lights retain the room hierarchy without stacked or clipped focal color.",
"visible_neutral": {},
"art_overrides": {},
"semantic_sha256": "2122d13accbe02dbaecc1445f98416b7a92c54301423f5b5b2b925e9dda492dd"
"semantic_sha256": "0096c67594121b028e44b327b63e1e1902c3afdbfdfd86c465b0fb0329d74648"
},
"maps/shattered_islands/world_17_2_5": {
"uncolored_disposition": "neutral",
Expand Down Expand Up @@ -4130,10 +4130,10 @@
},
"maps/shattered_islands/world_4_47": {
"uncolored_disposition": "neutral",
"rationale": "Rendered Asteria in the strakewood_island batch; neutral map-local fill preserves the outdoor ambient hierarchy while explicit emitters carry the scene's art cues.",
"rationale": "Rendered Asteria in the strakewood_island batch; neutral map-local fill preserves the outdoor ambient hierarchy. The crystal ball at (11, 18) is fixed fortune-teller display scenery co-located with its table and uses a small blue focal light.",
"visible_neutral": {},
"art_overrides": {},
"semantic_sha256": "b624147d29e798fb862489ca67d58cfe55d0d451c227b91745a0ff280aef90e9"
"semantic_sha256": "192c897b257e09a8a867621ca4609e778ac4491bd4f49aaa6dac68600aca18b1"
},
"maps/shattered_islands/world_4_48": {
"uncolored_disposition": "neutral",
Expand Down
3 changes: 3 additions & 0 deletions maps/shattered_islands/world_17_2_4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4701,6 +4701,9 @@ arch crystal_ball
sub_layer 1
z 26
align -4
no_pick 1
glow_radius 1
light_color 4060ff
x 22
y 9
end
Expand Down
3 changes: 3 additions & 0 deletions maps/shattered_islands/world_4_47
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,6 +2213,9 @@ end
arch crystal_ball
layer 5
z 23
no_pick 1
glow_radius 1
light_color 4060ff
x 11
y 18
end
Expand Down