Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update systemd service file #16

Merged
merged 5 commits into from
Jun 25, 2018
Merged

Update systemd service file #16

merged 5 commits into from
Jun 25, 2018

Conversation

paulfantom
Copy link
Collaborator

SuperQ
SuperQ reviewed Jun 25, 2018
View reviewed changes
templates/minio.service.j2 Outdated
@@ -33,5 +39,9 @@ SendSIGKILL=no

SuccessExitStatus=0

{% if minio_server_addr.split(':')[1] < 1024 %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break with v6 😁 [::1]:80.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now 😄

SuperQ
SuperQ approved these changes Jun 25, 2018
View reviewed changes
Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SuperQ
SuperQ requested changes Jun 25, 2018
View reviewed changes
Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some explicit tests for this?

@paulfantom
Copy link
Collaborator Author

@SuperQ I've added some tests. Unfortunatelly I don't see a way to test ipv6.

@SuperQ
Copy link
Collaborator

SuperQ commented Jun 25, 2018

Can you add an assert for the service file file.contains("AmbientCapabilities=CAP_NET_BIND_SERVICE"). That way we know the math works.

@paulfantom
Copy link
Collaborator Author

paulfantom commented Jun 25, 2018 •
edited
Loading

Seems redundant, since service won't start on port 80 without it, but I'll add it.

SuperQ
SuperQ approved these changes Jun 25, 2018
View reviewed changes
Copy link
Collaborator

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulfantom paulfantom merged commit a9fb916 into atosatto:master Jun 25, 2018
@paulfantom paulfantom deleted the systemd_service branch June 25, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

@atosatto atosatto Awaiting requested review from atosatto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfantom @SuperQ