Skip to content

hints files: Relax strict vars #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jkeenan
Copy link
Collaborator

@jkeenan jkeenan commented Aug 30, 2020

For: #251

I wrote a (Perl 7!) program to inspect these hints files and insert no strict 'vars;` where it was not already present.

I tested this branch on NetBSD. All tests PASSed. I inspected the output of make test_prep in locations near where these 3 files would have been processed:

$VAR1 = [
  'cpan/DB_File/hints/netbsd.pl',
  'ext/DynaLoader/hints/netbsd.pl',
  'ext/POSIX/hints/netbsd.pl'
];

I found no Variable ... not imported warnings.

Obviously, until we can get a strict-compliant Perl (7) tested on a wide variety of platforms, we won't be absolutely sure that these revisions are correct. But they should be good enough for an upcoming Merge Candidate.

Please review.

Thank you very much.
Jim Keenan

Copy link
Owner

@atoomic atoomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoomic
Copy link
Owner

atoomic commented Aug 31, 2020

Do we need to patch the cpan/* files with this?

@jkeenan
Copy link
Collaborator Author

jkeenan commented Aug 31, 2020

Do we need to patch the cpan/* files with this?

I'm not sure which cpan/* files you're referring to. Note that there are quite a few cpan/ files in the p.r.

jimk

@jkeenan jkeenan merged commit b5a0552 into atoomic:alpha-dev-02-strict Aug 31, 2020
@jkeenan jkeenan deleted the repair-hints-files-20200830 branch August 31, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants