forked from burrowers/garble
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix building for GOOS=darwin on Go 1.22.0
It seems like building with Go 1.22.0 for GOOS=darwin started running into some issues with the syscall package's use of ABIInternal in assembly source code: > exec garble build [stderr] # syscall [...].s:16: ABI selector only permitted when compiling runtime, reference was to "runtime.entersyscall" The error can be reproduced from another platform like GOOS=linux as long as we have any test that cross-compiles std to GOOS=darwin. We had crossbuild.txtar which only ensured we covered GOOS=windows and GOOS=linux, so add a third case to ensure MacOS is covered too. This will slow down the tests a bit, but is important for the sake of ensuring that we catch these bugs early, even without MacOS on CI. In fact, we hadn't caught this earlier for Go 1.22 precisely because on CI we only tested on Go tip with GOOS=linux, for the sake of speed. Adding the rest of the package import paths from objabi.allowAsmABIPkgs to our runtimeAndDeps generated map solves this error.
- Loading branch information
Showing
5 changed files
with
24 additions
and
9 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters