Add config for sts_credentials_region #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for fluentd deployments running in a different region than their elasticsearch cluster and want to take advantage of local sts endpoints
prudhvi
reviewed
Jun 5, 2020
prudhvi
reviewed
Jun 5, 2020
| @@ -20,6 +20,7 @@ class AwsElasticsearchServiceOutput < ElasticsearchOutput | |||
| config_param :ecs_container_credentials_relative_uri, :string, :default => nil #Set with AWS_CONTAINER_CREDENTIALS_RELATIVE_URI environment variable value | |||
| config_param :assume_role_session_name, :string, :default => "fluentd" | |||
| config_param :assume_role_web_identity_token_file, :string, :default => nil | |||
| config_param :sts_credentials_region, :string, :default => "" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Refactored the code for better testability, but held off on updating tests since it looks like tests are broken even on master.
cosmo0920
requested changes
Jun 9, 2020
Comment on lines
120
to
121
|
|
||
|
|
There was a problem hiding this comment.
Could you remove these newlines?
In Ruby style, using one newline between the functions is better.
| @@ -20,6 +20,7 @@ class AwsElasticsearchServiceOutput < ElasticsearchOutput | |||
| config_param :ecs_container_credentials_relative_uri, :string, :default => nil #Set with AWS_CONTAINER_CREDENTIALS_RELATIVE_URI environment variable value | |||
| config_param :assume_role_session_name, :string, :default => "fluentd" | |||
| config_param :assume_role_web_identity_token_file, :string, :default => nil | |||
| config_param :sts_credentials_region, :string, :default => nil | |||
There was a problem hiding this comment.
Could you add this parameter in README documentation?
https://github.com/atomita/fluent-plugin-aws-elasticsearch-service/blob/master/README.md
Only existing in plugin code, users don't get noticed this.
There was a problem hiding this comment.
Updated an example in the README to include this config option.
cosmo0920
approved these changes
Jun 9, 2020
|
@atomita Could you release the new version of this plugin? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for fluentd deployments running in a different region
than their elasticsearch cluster and want to take advantage of local sts
endpoints