AWS_CONTAINER_CREDENTIALS_RELATIVE_URI uses environment variables #64
Conversation
| @@ -17,7 +17,6 @@ class AwsElasticsearchServiceOutput < ElasticsearchOutput | |||
| config_param :access_key_id, :string, :default => "" | |||
| config_param :secret_access_key, :string, :default => "", secret: true | |||
| config_param :assume_role_arn, :string, :default => nil | |||
| config_param :ecs_container_credentials_relative_uri, :string, :default => nil #Set with AWS_CONTAINER_CREDENTIALS_RELATIVE_URI environment variable value | |||
There was a problem hiding this comment.
Removing config_param is not good.
If you remove it completely, please use :obsolete here.
There was a problem hiding this comment.
It's certainly not good.
Modify.
There was a problem hiding this comment.
How about refer AWS_CONTAINER_CREDENTIALS_RELATIVE_URI in #configure?
aws_container_credentials_relative_uri = opts[:ecs_container_credentials_relative_uri] || ENV["AWS_CONTAINER_CREDENTIALS_RELATIVE_URI"]There was a problem hiding this comment.
Ah, this should be in #credentails.
But, using instance variable to store credentials information in #configure is also OK for me
When using Fargate with ECS, there is no way to know the AWS_CONTAINER_CREDENTIALS_RELATIVE_URI. |
|
I think that this change breaks compatibility. |
|
Thank you for a good suggestion. |
|
I'm late. |
|
@atomita Could you release a new version which includes this change? |
Hello.
I use ECS.
Instead of writing the contents of the environment variable AWS _ CONTAINER _ CREDENTIALS _ RELATIVE _ URI to a configuration file, you may want to use it directly.
What do you think?