Skip to content

Add strict constraint ES plugin version #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Add strict constraint ES plugin version #53

merged 1 commit into from
Mar 4, 2019

Conversation

cosmo0920
Copy link
Collaborator

Since ES plugin v3.3.0, get_connection_options's arity is changed to 1 from 0.
We should add version constraint for ES plugin.

@cosmo0920 cosmo0920 requested a review from atomita March 4, 2019 05:51
@cosmo0920
Copy link
Collaborator Author

Ref: #52

atomita
atomita approved these changes Mar 4, 2019
View reviewed changes
Copy link
Owner

@atomita atomita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cosmo0920
Thank you for PR!

@atomita atomita merged commit 30aa1cc into master Mar 4, 2019
@cosmo0920 cosmo0920 deleted the add-strict-constraint-es-plugin branch March 4, 2019 06:57
@cosmo0920 cosmo0920 mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomita atomita atomita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmo0920 @atomita