Slow Gem Install Fix #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build gem via: ``` gem build fluent-plugin-aws-elasticsearch-service.gemspec ``` And confirmed new gem installs quickly and works as expected closes atomita#48
Closed
thadamski
changed the title
cosmo0920
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced aws-sdk Dependencies to only aws-sdk-core
Built gem via (you may want to bump the local version in the .gemspec first):
And confirmed new gem installs quickly and works as expected
closes #48
Edit: To do the
gem buildabove, you must have the project checked out via git, because the gemspec is using agitcommand to find the files to bundle, otherwise, you'll get an empty gem:https://github.com/atomita/fluent-plugin-aws-elasticsearch-service/blob/master/fluent-plugin-aws-elasticsearch-service.gemspec#L18