Merge pull request #3 from seyi-adeleke/feature/refactored-lga-function

feature(lga's): refactor lga function
atomicman57 · Jan 22, 2018 · 3460b25 · 3460b25
2 parents c4fcc8b + e5fbda3
commit 3460b25
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1 +1,2 @@
-node_modules
+node_modules/
+.idea/
diff --git a/index.js b/index.js
@@ -1,4 +1,4 @@
-var statesAndLocalGov = require('./src/statesAndLocalGov.json')
+var statesAndLocalGov = require('./src/statesAndLocalGov.json');
 
 module.exports = {
     all: function() {
@@ -8,23 +8,25 @@ module.exports = {
         var naijaStates = [];
         statesAndLocalGov.map(function (nigeriaStates){
             return naijaStates.push(nigeriaStates.state)
-        })
+        });
         return naijaStates;
     },
     lgas: function (state) {
-        state = state.toLowerCase().trim();
-        if(!state || state == ""){
+        var stateLocalGov;
+
+        if(!state || state.toLowerCase().trim() === ''){
             throw new Error('Invalid Nigeria State');
         }
+        state = state.toLowerCase().trim();
+
         if (state === 'fct' || state === 'f.c.t' || state === 'abuja' || state === 'f c t'){
             state = 'Federal Capital Territory'
         }
-        var stateLocalGov;
-        statesAndLocalGov.map(function (nigeriaStates) {
+        statesAndLocalGov.find(function (nigeriaStates) {
             if (nigeriaStates.state.toLowerCase() === state.toLowerCase().trim()){
-            return stateLocalGov = nigeriaStates.lgas;
+                return stateLocalGov = nigeriaStates.lgas;
             }
-        })
+        });
         return stateLocalGov;
     }
-  };
+};