Sidebar/search performance #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepio
reviewed
Mar 27, 2023
joepio
reviewed
Mar 27, 2023
| transition: height ${p => p.duration}ms ease-in-out; | ||
| const GridCollapser = styled.div<GridCollapserProps>` | ||
| display: grid; | ||
| grid-template-rows: ${({ open }) => (open ? '1fr' : '0fr')}; |
joepio
reviewed
Mar 27, 2023
| newAgent?.subject && toast.success('Signed in!'); | ||
| newAgent === undefined && toast.success('Signed out.'); | ||
| } catch (e) { | ||
| toast.error('Agent setting failed: ' + e.message); |
There was a problem hiding this comment.
Pretty sure there's a errorHandler function that should be used, which internally does the console.log and toast.error. That way we can still use something like sentry or bugsnag later.
joepio
requested changes
Mar 27, 2023
Polleps
force-pushed
the
sidebar/search-performance
branch
from
cd93174 to
71ec98c
Compare
joepio
reviewed
Mar 27, 2023
| const [isOpen, setIsOpen] = React.useState(initialState); | ||
|
|
||
| useEffect(() => { | ||
| console.log('opening details'); |
joepio
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
atomic-data-rust