Configure the SSL protocols and ciphers via attributes #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would normally use the nginx cookbook's extra_configs attribute for this but the template already specifies these, overriding anything I might put in the global configuration. While the current cipher list looks reasonable, recent security practices make it important for cookbook users to be able to choose their own cipher list.
|
@chewi do you consider this PR safe to merge with master. It seems you have spent some time with upgrade to 8.5.x. Anything remaining? How about the gitlab-workhorse you mentioned in other PR? I am about to merge it as all of the PR are pretty reasonable. Later fix potential issues with Travis etc. |
|
@epcim I believe so. Despite the (only slightly) outdated gitlab-workhorse, we've been using this in production a decent amount this past couple of weeks and haven't seen a single issue. I take it you're talking about all the PRs, not just this one. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would normally use the nginx cookbook's extra_configs attribute for this but the template already specifies these, overriding anything I might put in the global configuration.
While the current cipher list looks reasonable, recent security practices make it important for cookbook users to be able to choose their own cipher list.