Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update broken mirror workflow: #170

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Conversation

DanielKotik
Copy link
Contributor

  • Update Ubuntu environment (18.04 is deprecated)
  • Update checkout action (Node.js 12 actions are deprecated)
  • Update mirror action (0.4.0 -> 0.6.0): this fixes the mirror workflow
  • Change fetch depth to 0: Default is 1, but with 0 we get all history for all branches and tags.

- Update Ubuntu environment (18.04 is deprecated)
- Update checkout action (Node.js 12 actions are deprecated)
- Update mirror action (0.4.0 -> 0.6.0): this fixes the mirror workflow
- Change fetch depth to 0: Default is 1, but with 0 we get all history
  for all branches and tags.
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #170 (c70559c) into develop (76c10f5) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #170      +/-   ##
===========================================
- Coverage    97.65%   97.62%   -0.03%     
===========================================
  Files           13       14       +1     
  Lines         2086     2191     +105     
===========================================
+ Hits          2037     2139     +102     
- Misses          49       52       +3     
Impacted Files Coverage Δ
atoMEC/check_inputs.py 95.37% <0.00%> (-0.67%) ⬇️
atoMEC/__init__.py 99.04% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@timcallow timcallow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... bit surprised the coverage changes slightly, something to do with updating the Ubuntu version? It's too trivial to care about, I'm just curious why

@DanielKotik
Copy link
Contributor Author

DanielKotik commented Dec 29, 2022

LGTM... bit surprised the coverage changes slightly, something to do with updating the Ubuntu version? It's too trivial to care about, I'm just curious why

I guess this is related to the two lines of code I added. Obviously codecov counts github workflow files as part of the packages. Maybe CI related files (and other unrelated ones) can be excluded?

@DanielKotik DanielKotik merged commit ccb0898 into develop Dec 30, 2022
@DanielKotik DanielKotik deleted the fix-mirror-workflow branch December 30, 2022 11:45
This was referenced Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants