Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test suite to CI #159

Merged
merged 32 commits into from
Oct 23, 2022
Merged

Conversation

timcallow
Copy link
Contributor

Attempting to add test suite to CI. Let's see how it goes...

Copy link
Contributor

@DanielKotik DanielKotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would suggest to put the test workflow in an extra YAML file in the .github/workflows/ folder. Maybe call it just tests.yml. Then its logically separated from the the workflow for building and deploying the Sphinx documentation deployed at GitHub pages (gh-pages.yml). This comes also with more fine control about when the tests should be triggered (can of course be identical with when docs are triggered). Start test.yml with

name: docs
on:
  pull_request:
    branches:
      - master
      - develop
  push:
    branches:
      - master
      - develop
jobs:
  run-test-suite
  ...

.github/workflows/gh-pages.yml Outdated Show resolved Hide resolved
.github/workflows/gh-pages.yml Outdated Show resolved Hide resolved
@timcallow timcallow merged commit a4fc823 into atomec-project:develop Oct 23, 2022
@timcallow timcallow deleted the add_tests_to_CI branch October 23, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants