-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite to CI #159
Add test suite to CI #159
Conversation
Modify pressure test to include new functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would suggest to put the test workflow in an extra YAML file in the .github/workflows/
folder. Maybe call it just tests.yml
. Then its logically separated from the the workflow for building and deploying the Sphinx documentation deployed at GitHub pages (gh-pages.yml
). This comes also with more fine control about when the tests should be triggered (can of course be identical with when docs are triggered). Start test.yml
with
name: docs
on:
pull_request:
branches:
- master
- develop
push:
branches:
- master
- develop
jobs:
run-test-suite
...
Attempting to add test suite to CI. Let's see how it goes...