Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate JARs that are proper OSGi bundles #84

Merged
merged 2 commits into from
Jun 19, 2018

Conversation

manandbytes
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented May 28, 2018

Codecov Report

Merging #84 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
- Coverage     68.18%   68.04%   -0.15%     
+ Complexity     2135     2130       -5     
============================================
  Files           282      282              
  Lines          8965     8965              
  Branches       1024     1024              
============================================
- Hits           6113     6100      -13     
- Misses         2183     2192       +9     
- Partials        669      673       +4
Impacted Files Coverage Δ Complexity Δ
...src/main/java/bt/net/ConnectionHandlerFactory.java 88.23% <0%> (-11.77%) 4% <0%> (-1%)
bt-core/src/main/java/bt/net/ConnectionResult.java 60% <0%> (-10%) 6% <0%> (-1%)
bt-core/src/main/java/bt/BufferingMap.java 76.47% <0%> (-5.89%) 5% <0%> (-1%)
...re/src/main/java/bt/net/PeerConnectionFactory.java 72.07% <0%> (-5.41%) 18% <0%> (-2%)
...src/main/java/bt/net/IncomingHandshakeHandler.java 57.5% <0%> (-5%) 5% <0%> (-1%)
bt-core/src/main/java/bt/data/Bitfield.java 87.7% <0%> (-4.92%) 35% <0%> (-3%)
...t-core/src/main/java/bt/net/ByteChannelReader.java 84.7% <0%> (-2.36%) 32% <0%> (ø)
bt-core/src/main/java/bt/protocol/Protocols.java 61.53% <0%> (-1.29%) 26% <0%> (-1%)
.../main/java/bt/torrent/BitfieldBasedStatistics.java 82.5% <0%> (ø) 16% <0%> (ø) ⬇️
...ore/src/main/java/bt/net/SocketPeerConnection.java 65.07% <0%> (ø) 17% <0%> (ø) ⬇️
... and 6 more

@manandbytes manandbytes force-pushed the osgi-bundles branch 2 times, most recently from d611ec0 to cff8da5 Compare June 9, 2018 16:31
@manandbytes
Copy link
Contributor Author

I'd like to use Bt in OSGi container but this requires some extra headers in MANIFEST.MF. This generates such headers for any Maven module of type 'jar'.

I'm not sure why codecov/project check fails, looks like false negative for me.

@atomashpolskiy atomashpolskiy merged commit 3cde897 into atomashpolskiy:master Jun 19, 2018
@atomashpolskiy
Copy link
Owner

Yeah, there's a problem with JDK9 build, but it seems unrelated to your changes. Thanks!!

@manandbytes manandbytes deleted the osgi-bundles branch June 21, 2018 10:01
@manandbytes
Copy link
Contributor Author

Am I right that this has not been released yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants