Repository navigation
test: keep reaped browser processes marked stopped - #11235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A killed browser can be reaped between the signal-0 liveness probe and reading its Linux process state. The old fallback reported that completed exit as alive, allowing the browser cleanup poll to reverse an observed zombie exit and fail early.
Recheck signal-0 when the process-state read fails, preserving the existing fallback on platforms without
/procand keeping all browser termination assertions unchanged. A deterministic zombie-to-reaped regression fails against the original helper and passes with this fix. This is a confirmed race consistent with the CI symptom; the historical CI failure itself has not been reproduced.Validation:
PORTOS_PREGATE_MAX_WORKERS=4: all passed on macOS, including the simulated Linux reaping race.provider:codexreview (gpt-6.1-sol, low): clean, no findings.npm run pregate: passed (reported stages only; required CI remains authoritative).Closes #11233