Repository navigation
fix: use motion film look during document preview playback - #11230
Conversation
|
Completed the configured provider:codex review budget (two rounds):
Also corrected the Windows finishing-pass test to require the exact encoded output path, and split the two expensive exact-render parity samples into individually bounded tests without dropping assertions. Focused checks passed (44 server/browser tests across the validated files, 16 client tests); the latest pregate passed 613 server and 136 client checks plus lint/guards. Both reviewer rounds returned findings; all were addressed. The configured budget is exhausted, so this is budget-complete, not a claimed clean review of the final head. There are no GitHub review threads to resolve. Full CI is running on 70a5241. #11221 remains open for representative clip-rate throughput validation. This PR references it without closing it. Conventions Encoded
|
|
Merged as f4b3c41 after all checks in CI run 38207819507 passed, including CI Gate and Full CI Gate. Verified the final task head is an ancestor of main and the exact remote task branch is deleted. The managed local worktree/branch remain for PortOS cleanup. The configured two-round reviewer budget completed and all three reported findings were fixed. Local validation passed 44 focused server/browser tests, 16 client tests, and pregate (613 server and 136 client checks plus lint/guards). #11221 remains open for representative throughput validation; merging this functional improvement does not establish clip-rate playback. |
Document previews carry playback mode with each queued worker seek. Playing frames use the shared CSS film look and reusable motion overlays; pause, scrub and frame stepping restore the exact SVG finishing filter. Generated documents remain inside the OS-isolated preview worker, and final renders keep their exact filter by default.
Motion overlays paint above document and lyric layers without intercepting pointer events. Their nodes and canvas noise tiles are retained across frames. Trusted inline SVG filters rasterize those tiles once without granting image URL access; overlay layers blend directly with the document and preceding layers. Explicit frame steps update the audio position before the pause repaint, preserving moves smaller than 50 ms. Previews without audio retain their seek position.
The CI correction asserts that the film finishing pass receives the exact encoded output path, preserving the contract on Windows as well as Unix.
Validation:
Performance acceptance remains open in #11221. A preliminary same-page, headless-Chromium 390×219 synthetic 30 fps video probe counted requestVideoFrameCallback over 3 seconds while advancing the runtime's film frame: clean 16.20 fps, exact Neon rain 6.65 fps, motion Neon rain 15.27 fps, clean recheck 14.24 fps. This sample predates the texture/blending corrections and cannot establish clip-rate playback because even the unfiltered control fell below the clip rate. It also does not measure throughput of the isolated JPEG worker transport. This PR delivers the mode-switch behavior; #11221 remains open for representative throughput validation and any required transport work.
Refs #11221
The configured provider:codex review ran for both allowed rounds and reported three findings. All three were fixed and covered by regressions; the two-round budget is exhausted, so no clean verdict is claimed for the final head.