Repository navigation
Goal-fidelity rubric: credit data-driven send-link buttons - #10986
Merged
Merged
Conversation
The reviewer judged a mood board 'send to image/video' feature as missing its buttons because they render from a mapped [key, Icon, label] array rather than one literal element per destination. The rubric now credits that rendering path when the diff adds it, and still flags a helper with no JSX consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A goal-fidelity review judged the mood board image/video send-button feature as undelivered. It read the
moodBoardItemSendLinkshelper but missed theLinkbuttons, which render from a mapped[key, Icon, label]array rather than one literal element per button.The fix is in the rubric (
GOAL_FIDELITY_SYSTEM_PROMPT), because the diff and objective blocks already contained the JSX. It adds one paragraph that credits a mapped tuple-array render path when the diff adds it and its keys match the helper's. It exempts only that shape. A helper with no added JSX consumer, a key the helper doesn't return, or a missing destination still counts as missing.The regression test reconstructs the case. The helper plus the mapped-Link JSX judges
ship; the helper alone judgesfix-first.