Release v0.26.0 - Smart Stock Fund Notifications #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizardIndicator now uses absolute positioning with h-5 fixed height label containers to prevent the indicator from pushing inputs down.
Stock funds no longer prompt for action when the US stock market is closed (weekends and major holidays like New Year's, MLK Day, Presidents Day, Good Friday, Memorial Day, Juneteenth, Independence Day, Labor Day, Thanksgiving, and Christmas). This applies to both the ActionableFundsBanner and the nav badge count.
There was a problem hiding this comment.
Pull request overview
This PR introduces smart stock fund notifications that suppress action prompts when the US stock market is closed (weekends and holidays), adds a GitHub repository link to the backtest page, and fixes form input field alignment issues caused by wizard indicators.
Changes:
- Market-aware filtering for stock fund action prompts based on weekends and US market holidays
- GitHub repository link added to backtest page footer
- Form label heights standardized using fixed-height wrapper divs with relative positioning
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
packages/web/src/utils/format.ts |
Adds isStockMarketClosed() utility with weekend and holiday detection logic including Easter calculation |
packages/web/src/components/ActionableFundsBanner.tsx |
Filters out stock funds when market is closed using memoized market status check |
packages/web/src/components/Layout.tsx |
Applies market closed filter to navigation badge count for consistency |
packages/web/src/components/EntryForm.tsx |
Fixes wizard indicator alignment by using absolute positioning within fixed-height label containers |
pages/src/BacktestApp.tsx |
Adds GitHub repository link to footer |
package.json |
Version bump to 0.26.0 |
package-lock.json |
Version bump to 0.26.0 |
.changelogs/v0.26.0.md |
Release notes documenting all changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Change "Run the App" link text to "View on GitHub" for accuracy - Remove unnecessary useMemo in ActionableFundsBanner since isStockMarketClosed is a lightweight calculation - Use US Eastern Time (America/New_York) for market closed checks instead of local browser timezone - Fix holiday observance date calculation to handle month boundaries correctly using Date arithmetic
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This release improves the user experience by intelligently suppressing stock fund action prompts when the US stock market is closed, and fixes a visual alignment issue in entry forms.
New Features
Market-Aware Stock Fund Notifications
GitHub App Link
Bug Fixes
Form Input Alignment
h-5) across all form fields with wizard indicatorsTechnical Details
New Utility Functions
isStockMarketClosed(date?): Check if US stock market is closed on a given dateisUSMarketHoliday(date): Internal helper for holiday detectioncalculateEaster(year): Easter calculation for Good Friday determinationFiles Changed
packages/web/src/utils/format.ts- Added market closed detection utilitiespackages/web/src/components/ActionableFundsBanner.tsx- Filter stock funds on market closed dayspackages/web/src/components/Layout.tsx- Apply same filter to nav badge countpackages/web/src/components/EntryForm.tsx- Fixed label row heights for alignmentCommits