Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Remove realpathCache argument in fs.realpath #1269

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Conversation

winstliu
Copy link
Contributor

@winstliu winstliu commented Jul 6, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Node 6 removed the cache argument from fs.realpath as it switched to a much faster native implementation. See nodejs/node#3594 for details. As Atom is now on Node 8, this argument is currently sitting there doing...nothing.

Alternate Designs

None.

Benefits

Removal of a confusing argument from a bygone era.

Possible Drawbacks

None.

Applicable Issues

None, though I caught this when working on #1232.

The cache was removed in Node 6 in favor of a faster native implementation. We're on Node 8 now.
@Arcanemagus
Copy link

Would it be clearer to simply omit the options object?

@winstliu
Copy link
Contributor Author

winstliu commented Jul 6, 2018

Yes, it would 😀. Mind was on autopilot there.

@winstliu winstliu merged commit 208d0bb into master Jul 6, 2018
@winstliu winstliu deleted the wl-rm-realpath-cache branch July 6, 2018 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants