This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix multi-select shifting #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! |
Contributor
|
@simurai is this mergeable? |
Contributor
Author
Yes, I think so. Sorry, forgot to add labels. 😔 I'll merge it. 🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This fixes the tree-view from shifting to the left when selecting multiple files.
Alternate Designs
We could use a child selector like
.tree-view > .list-treeor both "states".full-menu, .multi-select, but having just a single class seems simpler and communicates its intend better.Benefits
No shifting.
Possible Drawbacks
None
Applicable Issues
Raised in #1115 (comment)
Possibly regressed in #1111