Settings view does not disable cleanly

[Ben3eeE]

Prerequisites

• Can you reproduce the problem in safe mode?
• Are you running the latest version of Atom?
• Did you check the debugging guide?
• Did you check the FAQs on Discuss?
• Are you reporting to the correct repository?
• Did you perform a cursory search to see if your bug or enhancement is already reported?

For more information on how to write a good bug report or enhancement request, see the CONTRIBUTING guide.

Description

Disabling settings-view package has some issues. Application:show-settings command still exists in palette and keybind ctrl+, and executing it opens a weird atom:\config file that causes atom to hang when saving it.

Same issue different package: atom/about#22

Steps to Reproduce

1. Open atom
2. Disable settings-view
3. (optional) Restart atom
4. Run application:show-settings from command palette or default keybinding ctrl+, on windows.

Expected behavior: Nothing or preferred atom to open the config file for editing.

Actual behavior: Weird non existing file opens that causes atom to hang when saving.

Versions

1.6.X
Windows 7.

[winstliu]

Again, this is because the relevant commands as well as keybindings are defined in Atom core.
https://github.com/atom/atom/blob/5464883c1ecc581ebe698bc2722b0fe51a7ccda5/src/browser/atom-application.coffee#L207
(Ctrl+, actually seems to be defined in both atom/atom as well as settings-view. It would be much better for it only to be registered in settings-view.)

[jsejcksn]

@50Wliu On macOS the reverse is true. Atom > Preferences would need to retain the keybinding in order for it to keep with macOS Human Interface Guidelines, and it would just need to be mapped to settings-view internally.

[damieng]

Packages can add menu items to other place. The settings-view package would need to conditionally add Atom > Preferences on macOS only. The real problem is there is no control over where package menu items appear today.