This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add better support for wikis #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
The following commands are now supported, in addition to
open-on-github:file:open-on-github:file-on-master(alias toopen-on-github:file)open-on-github:copy-urlopen-on-github:historyopen-on-github:repositoryIn addition, line suffixes are no longer appended for any wiki operations.
Alternate Designs
None.
Benefits
More robust wiki support
Possible Drawbacks
The only potential risky change is changing
getRepoURL()to normalize git URLs ending in.wikito/wiki, though the repo might just end in.wikiand not be an actual GitHub wiki. I don't see this as too big as a problem asisGitHubWikiURL()was already doing that test.Applicable Issues
None.