Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Consider only offering prebuilds for N-API v3 #330

@dennisameling

Description

@dennisameling

Summary

Since Node 8.11.2, N-API v3 has been supported. node-keytar is already built on N-API, but is still providing many prebuilds for Electron and NodeJS. Downside of this is that with every new major version release of either NodeJS or Electron, those prebuild targets have to be added.

Major libraries like sharp are now switching to N-API prebuilds only. E.g. if you compare Sharp 0.25.4 to 0.26.3, you'll see that in the newer version, only 6 prebuilds were needed, compared to 72 in the older one.

Building node-keytar for N-API is already possible today by running prebuild -t 3 -r napi.

Are you OK with switching to N-API prebuilds only, or are there reasons not to do that? I'm happy to provide a PR for it.

Motivation

Significantly reduces the amount of prebuilds that need to be generated for node-keytar.

Describe alternatives you've considered

N/A

Additional context

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions