Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

atomiks
Copy link

@atomiks atomiks commented Mar 20, 2019

Description of the Change

Adds more prorotype methods to support.function. For example with the Atom One Dark theme, these functions are a more cyan color compared to regular functions which are blue.

Includes

  • Array#{map,filter,reduce,reduceRight,flat,flatMap,every,some,includes,copyWithin}
  • Function#bind
  • Object#hasOwnProperty

Alternate Designs

Benefits

Less inconsistency in coloring when using methods

Possible Drawbacks

None that I am aware of

Applicable Issues


Ref: microsoft/TypeScript-TmLanguage#699

@atomiks atomiks mentioned this pull request Mar 22, 2019
@winstliu
Copy link
Contributor

Thanks very much for reaching out!

As you may have heard, we are migrating from our old first-mate grammar engine to the new Tree-sitter engine. This will enable a number of new features, more consistent syntax highlighting, and better performance, among other benefits. In order to free up our limited resources, we have decided to stop maintaining the first-mate grammar when there is a built-in Tree-sitter grammar available. Since this PR applies only to the first-mate grammar, we are going to close it.

Thanks again for your interest in Atom.

@winstliu winstliu closed this Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants