This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Re-implement embedded JSDoc JavaScript highlighting #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not part of the official JSDoc spec, yet occasionally used in-the-wild.
|
Sorry for not hearing your ping, mate. Crippling depression, etc, etc... I've probably missed other things at other repositories, too. :( |
|
Don't think so. This was the only one I specifically pinged you on. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Implements #497 using a single match instead of multiple begin/ends. Taken from the previous JSDoc implementation. Regexes are still a bit ugly, but less hacky than #497.
Alternate Designs
🔥 embedded JS highlighting in JSDoc as a whole.
Benefits
Arrays in JSDoc optional values should receive proper JavaScript highlighting.
Possible Drawbacks
Messy regexes = large potential for regressions. @Alhadis wrote some wonderful tests though.
Applicable Issues
#497
/cc @Alhadis - would you mind reviewing this? I'm still working on HTML caption support but thought that this was a good place to request a review.