Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

mozfreddyb
Copy link
Contributor

Requirements

I'm working a lot with SJS files. These are JS files that include some additional proprietary APIs that run on the server-side (predating NodeJS). See https://developer.mozilla.org/en-US/docs/Mozilla/httpd.js/HTTP_server_for_unit_tests#SJS:_server-side_scripts for more

Description of the Change

Added sjs to the list of supported filetypes

Alternate Designs

N/A

Benefits

Package supports more types of jS

Possible Drawbacks

sjs is not very widely used. It might overlap with other files that people use in atom?

Applicable Issues

N/A

@Alhadis
Copy link
Contributor

Alhadis commented Jan 16, 2017

sjs is not very widely used. It might overlap with other files that people use in atom?

Distribution looks okay; a GitHub search tosses up 53,137 results.

(Sorry, I'll get back to fixing File-Icons now, haha)

@mozfreddyb
Copy link
Contributor Author

Ah, good find. Syntactically most (but not all) of them look like JavaScript.

(No need to feel sorry at all! I'm glad someone is looking at my bug reports.)

@Alhadis
Copy link
Contributor

Alhadis commented Jan 16, 2017

You can use this if you'd like to harvest a list of search results (it'll result in a list of URLs that you can run through wget).

I'd make it more direct, but GitHub doesn't make harvesting files very easy... E.g., try opening those search-results in an incognito window. -_-

Don't worry, you won't get in trouble for using it. We use it at Linguist for gauging in-the-wild usage of new language definitions. =)

@winstliu
Copy link
Contributor

It looks like the majority are JavaScript, with a few binary files. So I think this is fine.

@winstliu winstliu merged commit 245162f into atom:master Jan 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants