Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@winstliu
Copy link
Contributor

@winstliu winstliu commented Dec 3, 2015

#206 is back! 🎉

Tested my changes locally and I think I can get everything working this time (it's hard to tell because I get ~50 spec failures on atom/atom). Will be pushing PRs to language-html and atom shortly.

/cc @atom/languages @slinto

Actually fixes #201

winstliu added a commit to atom/language-html that referenced this pull request Dec 3, 2015
winstliu pushed a commit that referenced this pull request Dec 3, 2015
Tokenize let and var as storage.type.var.js
@winstliu winstliu merged commit 2771d82 into master Dec 3, 2015
@winstliu winstliu deleted the wl-var-scope branch December 3, 2015 01:45
winstliu added a commit to atom/atom that referenced this pull request Dec 3, 2015
@jerone
Copy link

jerone commented Dec 3, 2015

@winstliu
Copy link
Contributor Author

winstliu commented Dec 3, 2015

Maybe not storage.type.var...does storage.type.constant sound better? /cc @MaximSokolov

@MaximSokolov
Copy link
Contributor

storage.type.const or just storage.type as styles for constant can affect "constant" keyword
(see atom/language-go#63 (comment))

Related question: Is const in const int i; a "modifier" or it's storage.type as well?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow naming conventions

4 participants