Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Allow $dollar$ signs in identifiers #272

Merged
merged 3 commits into from
Nov 27, 2015
Merged

Allow $dollar$ signs in identifiers #272

merged 3 commits into from
Nov 27, 2015

Conversation

MaximSokolov
Copy link
Contributor 

0illegal()
$abc$()
$()
$obj$.$abc$()
$.$()
$.$
$.$prop$
$.CON$TANT
$.C$
class $
class $abc$ extends $
class extends $abc

Before:
before
After:
after

Fixes #270
Fixes #268

MaximSokolov
MaximSokolov reviewed Nov 27, 2015
View reviewed changes
grammars/javascript.cson
'beginCaptures':
'1':
'name': 'entity.name.function.js'
'name': 'invalid.illegal.js'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without invalid.illegal it would be ...(?:\\$+)?\\b[a-zA-Z_][\\w$]*)...

@Victorystick
Copy link
Contributor

I'm loving this!

winstliu pushed a commit that referenced this pull request Nov 27, 2015
Merge pull request #272 from MaximSokolov/allow-dollar-signs-in-names
73040b7 
Allow $dollar$ signs in identifiers
@winstliu winstliu merged commit 73040b7 into atom:master Nov 27, 2015
@MaximSokolov MaximSokolov deleted the allow-dollar-signs-in-names branch November 27, 2015 16:08
@winstliu
Copy link
Contributor

🍧

Wow. You're really on top of things @MaximSokolov.

@MaximSokolov MaximSokolov mentioned this pull request Dec 15, 2015
Closed
@winstliu winstliu mentioned this pull request Jan 18, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
under-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximSokolov @Victorystick @winstliu