Pull in Latest from csharp-tmLanguage #132
Conversation
| @@ -1824,7 +1824,7 @@ repository: | |||
| } | |||
| ] | |||
| "7": | |||
| name: "variable.other.cs" | |||
| name: "entity.name.variable.local.cs" | |||
There was a problem hiding this comment.
As far as I remember, we are currently not just keeping the grammar from upstream here, but also applying a few patches specific to GitHub C# code rendering engine. For example, this includes the following patch: e3a379f These name directives are used to determine which color to use for the highlighting. So we should test this grammar here https://github-lightshow.herokuapp.com/ to avoid regressions. E.g. in the grammar used by GitHub and Atom, we change a few name directives to enable the highlighting of method calls.
There was a problem hiding this comment.
E.g. if I pull the grammar as is and try using it in the GitHub code highlighting engine, I get a regression. Use the following link to test it. This is how it looks like now:
And this is how the C# grammar from the main branch of this repository looks like:
I suppose we should adjust the grammar from the upstream to avoid regressions.
Requirements
Description of the Change
Pull in Latest from dotnet/csharp-tmLanguage
Alternate Designs
Benefits
Staying up to date with upstream grammar
Possible Drawbacks
There could be an upstream regression
Applicable Issues